Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict admin to delete default site #1439

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Restrict admin to delete default site #1439

wants to merge 8 commits into from

Conversation

Alihassanc5
Copy link
Collaborator

@Alihassanc5 Alihassanc5 commented Oct 25, 2022 •
edited
Loading

Closes #1328

  • Previously app crashes when there were no default site exist in database.
  • This problem is solved by restrict the admin to have at least one default site.
  • Admin cannot delete default site (if there is only one site)
  • For multiple sites admin can delete sites (except default site)

image

@Alihassanc5 Alihassanc5 marked this pull request as ready for review October 26, 2022 14:15
@sheralim012 sheralim012 marked this pull request as draft December 26, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes if there is no default 'Site'
1 participant
@Alihassanc5