Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22326 logKnownIssue skip for exhaustive test failures with kxv(_Deva)? day/month names #2690

Conversation

pedberg-icu
Copy link
Contributor

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22326
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@pedberg-icu
Copy link
Contributor Author

/azp run CI-Exhaustive

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

markusicu
markusicu previously approved these changes Oct 27, 2023
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tnx!

@pedberg-icu pedberg-icu force-pushed the ICU-22326-skip-exhaustive-failure-with- branch from 46face8 to cc1d205 Compare October 27, 2023 20:03
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@pedberg-icu
Copy link
Contributor Author

/azp run CI-Exhaustive

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pedberg-icu
Copy link
Contributor Author

Any TC member, feel free to merge when this passes tests and is approved, thanks

@pedberg-icu
Copy link
Contributor Author

pedberg-icu commented Oct 27, 2023

Hooray! The files in the branch are the same across the force-push. 😃

Oops, needed separate skips for day names and month names, fixed now (and Markus re-approved, thanks!)

@markusicu markusicu merged commit d44f5bc into unicode-org:maint/maint-74 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants