ICU-22879 Provide collator based predicates for use with STL algorithms #3149
Conversation
roubert
force-pushed
the
22879
branch
3 times, most recently
from
82c9a62 to
e019452
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
| assertTrue("string", equal_to(std::string{TEXT_CHAR}, TEXT_CHAR)); | ||
| } | ||
|
|
||
| void CollationTest::TestCollatorMap() { |
There was a problem hiding this comment.
I wanted to see how things would work with std::map, so I tried it out.
Might be worth putting examples using that to the API documentation.
There was a problem hiding this comment.
Examples would be very good but not a blocker for this PR. Happy to re-approve with more examples, and also happy to approve a follow-up.
| assertTrue("string", equal_to(std::string{TEXT_CHAR}, TEXT_CHAR)); | ||
| } | ||
|
|
||
| void CollationTest::TestCollatorMap() { |
There was a problem hiding this comment.
Examples would be very good but not a blocker for this PR. Happy to re-approve with more examples, and also happy to approve a follow-up.
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Checklist
ALLOW_MANY_COMMITS=true