-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22843 Disambiguate UnicodeString::readOnlyAlias() for MSVC #3150
Conversation
The test case in the first commit fails like this with MSVC: https://github.com/unicode-org/icu/actions/runs/10816568529/job/30008039132?pr=3150 The fix in the second commit makes the test case work also with MSVC. |
@richgillam FYI |
good catch! |
f3fdc7e
to
0c4152a
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Both std::u16string_view and std::wstring_view are possible matches for UnicodeString as a template parameter, but adding an explicit overload avoids both having to make that choice and taking the detour through creating any string view at all.
0c4152a
to
837e0f6
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Both
std::u16string_view
andstd::wstring_view
are possible matches forUnicodeString
as a template parameter, but adding an explicit overload avoids both having to make that choice and taking the detour through creating any string view at all.Checklist
ALLOW_MANY_COMMITS=true