Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22723 BRS_76_RC: Update version number to 76.1-SNAPSHOT #3173

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

rp9-next
Copy link
Contributor

@rp9-next rp9-next commented Sep 17, 2024

Ready to merge once approved

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22723
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@rp9-next rp9-next marked this pull request as ready for review September 17, 2024 10:47
markusicu
markusicu previously approved these changes Sep 17, 2024
@rp9-next
Copy link
Contributor Author

@mihnita, could you please review if icu4j changes are ok?
I don't want to make maven unhappy (I recall I missed a few things last time which was then fixed by @yumaoka )

@rp9-next rp9-next requested a review from yumaoka September 18, 2024 09:47
@mihnita
Copy link
Contributor

mihnita commented Sep 18, 2024

LGTM and approved.

Two nitpicks:


./tools/cldr/cldr-to-icu/pom.xml contains <version>76.0.1-SNAPSHOT</version>

It does not matter much. It does not affect anything, really.
We can decided to fix it to some value forever.
But just for completeness would be nice to keep it in sync, for now.


./icu4j/main/core/src/test/java/com/ibm/icu/dev/test/util/DebugUtilitiesData.javacontainspublic static final String ICU4C_VERSION="76.0.1";`

It is only used in one place, in a log statement in test.

We should probably remove it.
The log can probably take the version from official APIs, which is more reliable anyway than a hard-coded string.

mihnita
mihnita previously approved these changes Sep 18, 2024
Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you,
Mihai

@rp9-next rp9-next dismissed stale reviews from mihnita and markusicu via 3c21649 September 19, 2024 08:04
@rp9-next rp9-next force-pushed the brs_76rc_version_update branch from f863ab9 to 3c21649 Compare September 19, 2024 08:04
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/processes/release/tasks/versions.md is now changed in the branch
  • icu4j/main/core/src/test/java/com/ibm/icu/dev/test/util/DebugUtilitiesData.java is now changed in the branch
  • tools/cldr/cldr-to-icu/pom.xml is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihnita ok now?

@markusicu markusicu requested a review from mihnita September 19, 2024 15:22
@rp9-next rp9-next merged commit 30efee0 into unicode-org:main Sep 19, 2024
101 checks passed
@rp9-next rp9-next deleted the brs_76rc_version_update branch September 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants