Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22919 Enable CI with JDK 21 and fix the json parsing #3214

Merged
merged 1 commit into from
Sep 25, 2024
Merged

ICU-22919 Enable CI with JDK 21 and fix the json parsing #3214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/icu4j.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,15 @@ jobs:
run: |
cd icu4j;
mvn ${SHARED_MVN_ARGS} dependency:go-offline -P '!old_jdk_taglet'

# ICU4J build and unit test using Maven
# https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-maven
icu4j-mvn-build-and-test:
needs: icu4j-mvn-init-cache
strategy:
fail-fast: false
matrix:
java-version: [ '8', '11', '17' ]
java-version: [ '8', '11', '17', '21' ]
runs-on: ubuntu-latest
steps:
- name: Checkout and setup
Expand Down
15 changes: 3 additions & 12 deletions testdata/message2/more-functions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,19 +102,10 @@
},
{
"src": "Default int64: {$val}!",
"exp": "Default int64: 1.234.567.890.123.456.800!",
"exp": "Default int64: 1.234.567.890.123.456.789!",
"locale": "ro",
"params": [{ "name": "val", "value": 1234567890123456789 }],
"comment": "Rounded due to JSON not supporting full 64-bit ints",
"ignoreJava": "See https://unicode-org.atlassian.net/browse/ICU-22754?focusedCommentId=175932"
},
{
"src": "Default int64: {$val}!",
"exp": "Default int64: 1.234.567.890.123.456.770!",
"locale": "ro",
"params": [{ "name": "val", "value": 1234567890123456789 }],
"comment": "Rounded due to JSON not supporting full 64-bit ints",
"ignoreCpp": "See https://unicode-org.atlassian.net/browse/ICU-22754?focusedCommentId=175932"
"params": [{ "name": "val", "value": {"decimal": "1234567890123456789"} }],
"comment": "Rounded due to JSON not supporting full 64-bit ints"
},
{
"src": "Default number: {$val}!",
Expand Down