Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22954 Workaround to make the icu4c-windows-cygwin-gcc CI job work #3322

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

roubert
Copy link
Member

@roubert roubert commented Dec 30, 2024

For some unknown reason the use of std::u16string in class IcuTestErrorCode since commit 5dff777 causes the icu4c-windows-cygwin-gcc CI job to fail.

Checklist

  • Required: Issue filed: ICU-22954
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

There's no reason to ever make a copy of these objects, existing code
that does this is doing it by mistake.
@roubert roubert requested a review from markusicu December 30, 2024 14:14
@roubert roubert marked this pull request as ready for review December 30, 2024 14:14
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@roubert roubert merged commit df0422e into main Jan 7, 2025
112 checks passed
@roubert roubert deleted the roubert-debug-cygwin branch January 7, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants