ICU-22991 Reduce fStamp to 8 bits #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYFTang
force-pushed
the
ICU-22991-reduceStamp
branch
from
2673453 to
e087df3
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
FrankYFTang
force-pushed
the
ICU-22991-reduceStamp
branch
from
e087df3 to
98b06dd
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
FrankYFTang
force-pushed
the
ICU-22991-reduceStamp
branch
from
98b06dd to
b31ce36
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
markusicu
reviewed
Jan 3, 2025
FrankYFTang
force-pushed
the
ICU-22991-reduceStamp
branch
from
01ed02b to
4cc9027
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
markusicu
previously approved these changes
Jan 6, 2025
FrankYFTang
force-pushed
the
ICU-22991-reduceStamp
branch
from
c49a430 to
cba1319
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Somehow for MSVC, we need one more bit to store the enum. May be a sign conversion bug. |
markusicu
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce 24x3=72 bytes per Calendar object by changing from 32 bits integer to 8 bits integer for the stamp array.
Reset the fNextStamp whenever we clear the fStamp. There are at most 24 different stamp values stored inside fStamp so using 7 bits to store up to 127 different one should be enough.
Also change to use bit fields for:
fIsTimeSet, fAreFieldsSet, fAreAllFieldsSet, fAreFieldsVirtuallySet, fLenient, fRepeatedWallTime, fSkippedWallTime, fFirstDayOfWeek, fWeekendOnset, fWeekendCease to save more space
Checklist