Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musical notes and rests #890

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GenerateEnums
eggrobin committed Jul 25, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit b2713701b3aeb573757b263f9c277f617323fada
Original file line number Diff line number Diff line change
@@ -394,6 +394,7 @@ public enum Block_Values implements Named {
Mro("Mro"),
Multani("Multani"),
Musical_Symbols("Music"),
Musical_Symbols_Supplement("Music_Sup"),
Myanmar("Myanmar"),
Myanmar_Extended_A("Myanmar_Ext_A"),
Myanmar_Extended_B("Myanmar_Ext_B"),

Unchanged files with check annotations Beta

# Show [\p{GC=Mc} & \p{alphabetic}]
\p{Whitespace} ⊃ [\p{GC=Zs} \p{GC=Zp} \p{GC=Zl}]

Check failure on line 670 in unicodetools/src/main/resources/org/unicode/text/UCD/UnicodeInvariantTest.txt

GitHub Actions / Check UCD consistency, invariants, smoke-test generators

Invariant test failure

Expected empty, got: 3 [\U0001D250-\U0001D252] In [\p{GC=Lu} \p{GC=Ll} \p{GC=Lt} \p{GC=Lm} \p{GC=Lo} \p{GC=Nl} \p{GC=Mc} - $AlphaExclusions] But Not In \p{Alphabetic} 1D250..1D252 # [3] (�..�) MUSICAL SYMBOL COMBINING FLAG-6..MUSICAL SYMBOL COMBINING FLAG-8
\p{GC=Zs} ≉ \p{Name=/SPACE/}
\p{Dash} ⊃ [\p{GC=Pd}]
# We would also need to separately check that the characters are T or V only
# appear in canonical decompositions where they follow an LV, LVT, V, or T, or
# an LV or V, respectively.
[\p{NFC_QC=Maybe}&\p{ccc=0}] ⊆ [\p{GCB=Extend}\p{GCB=T}\p{GCB=V}]

Check failure on line 1028 in unicodetools/src/main/resources/org/unicode/text/UCD/UnicodeInvariantTest.txt

GitHub Actions / Check UCD consistency, invariants, smoke-test generators

Invariant test failure

Expected empty, got: 3 [\U0001D250-\U0001D252] In \P{ ccc=0} But Not In \p{ GCB=Extend} 1D250..1D252 # [3] (�..�) MUSICAL SYMBOL COMBINING FLAG-6..MUSICAL SYMBOL COMBINING FLAG-8
# Canonical decomposition preserves the initial GCB, except for LV and LVT.
In [\p{dt=canonical}-[\p{gcb=LV}\p{gcb=LVT}]], gcb * (take 1) * dm = gcb
# “Multiple values are not assigned to characters with strong restrictions:
# Not_Character, Deprecated, Default_Ignorable, Not_NFKC.”
\p{Identifier_Type=Deprecated} = \p{Deprecated}

Check notice on line 13 in unicodetools/src/main/resources/org/unicode/text/UCD/SecurityInvariantTest.txt

GitHub Actions / Check security data invariants

Invariant test failure

Expected empty, got: 6 [\U0001D250-\U0001D255] In \p{Identifier_Type=Not_Character} But Not In [\p{gc=Cn}\p{gc=Co}\p{gc=Cs}\p{gc=Cc}-\p{White_Space}] 1D250..1D255 # [6] (�..�) MUSICAL SYMBOL COMBINING FLAG-6..MUSICAL SYMBOL ONE THOUSAND TWENTY-FOURTH REST
# When a code point fits the criteria for multiple restrictions, then the strongest one wins.
# For example, Default_Ignorable is trumped by unassigned and Deprecated.
# DerivedAge-16.0.0.txt

Check warning on line 1 in unicodetools/data/ucd/dev/DerivedAge.txt

GitHub Actions / Draft unless approved

Not in the 16.0 pipeline

These characters are neither accepted for Unicode 16.0, nor for any specific version of Unicode, nor are they provisionally assigned. The Age property values for new characters are likely incorrect right now. They will be recomputed after the UTC accepts their encoding and this pull request is updated for the target version.

Check warning on line 1 in unicodetools/data/ucd/dev/DerivedAge.txt

GitHub Actions / Draft unless approved

Not in the 16.0 pipeline

These characters are neither accepted for Unicode 16.0, nor for any specific version of Unicode, nor are they provisionally assigned. The Age property values for new characters are likely incorrect right now. They will be recomputed after the UTC accepts their encoding and this pull request is updated for the target version.

Check warning on line 1 in unicodetools/data/ucd/dev/DerivedAge.txt

GitHub Actions / Draft unless approved

Not in the 16.0 pipeline

These characters are neither accepted for Unicode 16.0, nor for any specific version of Unicode, nor are they provisionally assigned. The Age property values for new characters are likely incorrect right now. They will be recomputed after the UTC accepts their encoding and this pull request is updated for the target version.
# Date: 2024-07-25, 15:19:16 GMT
# © 2024 Unicode®, Inc.
# Unicode and the Unicode Logo are registered trademarks of Unicode, Inc. in the U.S. and other countries.