runtime: remove some build warnings #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
Don-Ward
approved these changes
Mar 27, 2024
| @@ -4060,7 +4060,8 @@ int strimage(wbp w, | |||
| } | |||
| } | |||
| else { | |||
| int lastr=-1, lastg=-1, lastb=-1, count = 0; | |||
| int lastr=-1, lastg=-1, lastb=-1; | |||
| //int count = 0; | |||
There was a problem hiding this comment.
I've been looking at the history of this block of code. count was introduced by commit f1c1257 in 2007. It wasn't used then (except to be incremented for no apparent purpose) and it has never been used up to today. I'm content for you to comment it out, but I wonder why we don't just delete it.
ValG4
pushed a commit
to ValG4/unicon
that referenced
this pull request
Dec 7, 2024
runtime: remove some build warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.