Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LSIF capability to ULSP #504

Closed
wants to merge 0 commits into from

Conversation

nshapiro4
Copy link
Contributor

Adds lsif.icn into the uni/ulsp directory. This works as a command option in the ulsp command. Can be used to generate LSIF information from a specific directory, or all directories targeted by ulsp.

@Jafaral
Copy link
Member

Jafaral commented Feb 23, 2025

You have a merge commit, you can please rebase on top of master?

@jschnet
Copy link
Contributor

jschnet commented Feb 24, 2025

The output.lsif file probably shouldn't be part of the source, unless told otherwise. This can be removed by adding a line to the .gitignore file instead, right after that ulsp line.

Also would be good to remove this file while cleaning using the Makefile, i.e. make clean.

If we anticipate there being more than just this one output file in the future, having a directory called outputs/ in here would make things easier since there would be less to add for instances like this since we can just add that directory to the .gitignore and Makefile rather than each individual file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants