Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LSIF functionality #510

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Add LSIF functionality #510

merged 1 commit into from
Mar 7, 2025

Conversation

nshapiro4
Copy link
Contributor

No description provided.

@nshapiro4 nshapiro4 force-pushed the lsif-implementation branch from 36f2bbb to 994be5d Compare March 3, 2025 19:00
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral requested changes Mar 4, 2025
View reviewed changes
Copy link
Member

@Jafaral Jafaral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. See my comments.

@nshapiro4 nshapiro4 force-pushed the lsif-implementation branch 2 times, most recently from 84bb120 to b08da34 Compare March 4, 2025 17:58
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 4, 2025
View reviewed changes
@nshapiro4 nshapiro4 force-pushed the lsif-implementation branch from b08da34 to c8cfc4e Compare March 4, 2025 20:47
Jafaral
Jafaral reviewed Mar 5, 2025
View reviewed changes
@nshapiro4 nshapiro4 force-pushed the lsif-implementation branch from c8cfc4e to 561465a Compare March 5, 2025 16:27
Jafaral
Jafaral reviewed Mar 5, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 5, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 5, 2025
View reviewed changes
Jafaral
Jafaral reviewed Mar 6, 2025
View reviewed changes
@nshapiro4 nshapiro4 force-pushed the lsif-implementation branch 2 times, most recently from bc1ebf6 to ad02802 Compare March 6, 2025 21:32
Jafaral
Jafaral reviewed Mar 6, 2025
View reviewed changes
@nshapiro4 nshapiro4 force-pushed the lsif-implementation branch from ad02802 to 835b046 Compare March 6, 2025 21:40
@Jafaral Jafaral merged commit 45724c7 into uniconproject:master Mar 7, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jafaral Jafaral Jafaral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nshapiro4 @Jafaral