Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloud): Populate rootfs deployer message for prompting #1892

Merged

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

@craciunoiuc craciunoiuc force-pushed the craciunoiuc/fix-lingering-prompt branch from 8076b66 to ecabd29 Compare September 18, 2024 13:57
@craciunoiuc craciunoiuc changed the title fix(cloud): Do not show suggestion if only one option fix(cloud): Remove empty deployer before checking candidates Sep 18, 2024
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/fix-lingering-prompt branch from ecabd29 to 3f817cc Compare January 21, 2025 09:06
@nderjung nderjung changed the title fix(cloud): Remove empty deployer before checking candidates fix(cloud): Populate rootfs deployer message for prompting Jan 21, 2025
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Reviewed-by: Alexander Jung [email protected]
Approved-by: Alexander Jung [email protected]

@nderjung nderjung merged commit 6a836a7 into unikraft:staging Jan 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants