Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: match version only in project definition #19

Merged
merged 5 commits into from
Nov 21, 2023
Merged

fix: match version only in project definition #19

merged 5 commits into from
Nov 21, 2023

Conversation

sheerlox
Copy link
Member

Description

Update the regular version regex to only match version declarations inside the project function definition.

Related Issue

Fixes #15.

How Has This Been Tested?

Added new test cases and updated the existing ones.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

@sheerlox sheerlox added the bug Something isn't working label Nov 21, 2023
@sheerlox sheerlox merged commit 47a848d into main Nov 21, 2023
15 checks passed
@sheerlox sheerlox deleted the fix/match-version-only-in-project branch November 21, 2023 02:00
sheerlox pushed a commit that referenced this pull request Nov 21, 2023
@semantic-release-bot
chore(release): v1.0.3 [skip ci]
63563e8 
## [1.0.3](v1.0.2...v1.0.3) (2023-11-21)

### 🐛 Bug Fixes

* only match the version in project definition ([#19](#19)) ([47a848d](47a848d))

### ♻️ Chores

* **deps:** lock file maintenance ([93a1193](93a1193))
* **deps:** update dependency semantic-release to v22.0.8 ([d7c4e2f](d7c4e2f))
@sheerlox
Copy link
Member Author

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit the version: "..." match to the project function
1 participant
@sheerlox