-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use int32 as default int representation in windows #1179
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Niels Bantilan <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
==========================================
- Coverage 97.23% 97.03% -0.20%
==========================================
Files 65 65
Lines 5067 5067
==========================================
- Hits 4927 4917 -10
- Misses 140 150 +10
☔ View full report in Codecov by Sentry. |
Signed-off-by: Niels Bantilan <[email protected]>
/review |
Code Review Agent Run #722777Actionable Suggestions - 1
Additional Suggestions - 1
Review Details
|
Changelist by BitoThis pull request implements the following key changes.
|
if platform.system() == "Windows": | ||
assert default_int_dtype == np.dtype("int32") | ||
else: | ||
assert default_int_dtype == np.dtype("int64") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using platform.machine()
instead of platform.system()
to check for architecture since integer size is typically architecture dependent rather than OS dependent. On 32-bit systems, default int is 32-bit while on 64-bit systems it's 64-bit.
Code suggestion
Check the AI-generated fix before applying
if platform.system() == "Windows": | |
assert default_int_dtype == np.dtype("int32") | |
else: | |
assert default_int_dtype == np.dtype("int64") | |
if platform.machine() in ["i386", "x86"]: | |
assert default_int_dtype == np.dtype("int32") | |
else: | |
assert default_int_dtype == np.dtype("int64") |
Code Review Run #722777
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
fixes #726