-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dropping invalid rows for pyspark backend #1639
Open
zaheerabbas21
wants to merge
6
commits into
unionai-oss:main
Choose a base branch
from
zaheerabbas21:feature/pyspark-full-table-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+187
−37
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ba02957
Add `PANDERA_FULL_TABLE_VALIDATION` config for full table validation
zaheerabbas21 eed319c
Modify all builtin_checks for pyspark backend to support full table v…
zaheerabbas21 cd2f76c
Use the same function signature for builtin_checks across backends
zaheerabbas21 1f952d1
Add full_table_validation as a flag to config context func
zaheerabbas21 14513a6
Fix broken tests and add new tests for full_table_validation config
zaheerabbas21 86a34a4
Merge branch 'main' into feature/pyspark-full-table-validation
cosmicBboy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of passing this in as an argument, you can use
pandera.config.get_config_context
to get thefull_table_validation
configuration value. This is so that the API for each check is consistent across the different backends.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cosmicBboy. Will make the recommended change.
Also, is there a way that you can suggest to keep the
PANDERA_FULL_TABLE_VALIDATION
config value to beFalse
when the backend is pyspark andTrue
when the backend is pandas? Did not find a good way to do this, hence asking for a suggestion 😅.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the
config_context
context manager in the validate methods for each backend to control this behavior: https://github.com/unionai-oss/pandera/blob/main/pandera/config.py#L71for example this is used in the polars backend:
pandera/pandera/api/polars/container.py
Line 53 in c24dda9