-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with Cudf #969
base: main
Are you sure you want to change the base?
Conversation
this is awesome @pprados ! This PR will also need to add tests to ensure that the pandera API works well with cudf (from experience there might be weird quirks in differences between pandas and other pandas-like frameworks) For an example, you can take a look at the test suites for the other frameworks: |
The problem with the test for cudf, is, you must have an nvidia card in docker. What do you advise me to do to comply with your platform? |
I don't know too much about cudf, but is there a "cpu mode" to at least test that the code runs as expected? How does the cudf project do testing? |
Non. cudf is a GPU implementation of Pandas. All methods run inside the NVidia card. It's not possible to test, without GPU. |
Cool, lemme look into getting a self-hosted GPU runner for this project. https://cirun.io also looks promising, which supports GPU runners. In the mean-time, would you mind adding tests to this PR? Once the CI runners are up we can add those tests to the ci suite. |
Ok. I will add some similar test of others frameworks. |
How you start yours tests? |
See here for more info in general re: contributing |
I suppose the process to instal a conda environment to build have some mistake.
|
looks like |
once #973 is merged you can rebase on that and it should fix the error |
Cool. |
nice, yeah we can add some conditional logic to the CI workflow once #973 is ready |
To test modin, I must set some specific environment variable? |
are you seeing an error/warning? |
I need rebase from master?
fail Note: with pyspark, I have this error:
|
The current version has bugs. Wait a moment. I will fix it. |
I rebase the code from the branch fix-dependencies. It's not enough. The pyspark-stubs pose some problems. |
The current version rebase from fix-dependencies and propose all tests for cudf. |
thanks @pprados! will review this and start getting the CI stuff ready. A quick look at the diff, there's some commented out code in the tests, is this WIP or did you mean to delete those? |
Hello. But, I have some problem with
|
Ah, yeah I recently replaced the |
Just for information, I need this PR to combine your framework Pandera with another : Virtual DataFrame I would like to propose a link to Pandera, but I can do it, only, if Pandera is compatible with cudf. May be, later, we can add a mutual link. ;-) |
hi @pprados, due to the security issues associated with using self-hosted runners on a public repo, I'm inclined to wait for gpu-enabled github-hosted runners to add CI for this. We'll continue to explore options in this repo but to expedite your work, I'd be happy to help merge this into
Your English seems strong to me! If you can start a new docs page under this one I can help edit it. Basically you can roughly follow the structure in https://github.com/unionai-oss/pandera/blob/main/docs/source/modin.rst (with a |
Cool. For my project, i would like to found a solution for my ci. I will
try to document my pull request the next week.
Le dim. 13 nov. 2022 à 22:17, Niels Bantilan ***@***.***> a
écrit :
… hi @pprados <https://github.com/pprados>, due to the security issues
associated with using self-hosted runners on a public repo
<https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners#self-hosted-runner-security>,
I'm inclined to wait for gpu-enabled github-hosted runners
<github/roadmap#505> to add CI for this.
We'll continue to explore options in this repo
<#970> but to expedite your
work, I'd be happy to help merge this into main and tag it as
"experimental" in the documentation.
My English is too weak to work on the documentation.
Your English seems strong to me! If you can start a new docs page under this
one
<https://github.com/unionai-oss/pandera/blob/main/docs/source/supported_libraries.rst>
I can help edit it. Basically you can roughly follow the structure in
https://github.com/unionai-oss/pandera/blob/main/docs/source/modin.rst
(with a SKIP_CUDF in the :skipif: option) so that the code doesn't
actually run.
—
Reply to this email directly, view it on GitHub
<#969 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABR7FSSZ6X4TQBKC4RWWNTWIFLFLANCNFSM6AAAAAARH3ZOLY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: Niels Bantilan <[email protected]>
Missing: unit tests
Hello,
Nvidia propose a compatible Panda like framework to use the GPU : cudf
This pull-request add the compatibility to cudf.
Regards