feat: Increase coverage. #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unioslo#483 First pass: - Add pragma to exempt lines from coverage to .coveragerc - Add test for stringifying HostPolicyComponent-based objects (see unioslo#482) - Mock host_permissions/user_in_required_groups as its not supported by default. - Ensure that IsSuperOrAdminOrReadOnly is tested for unauthenticated users (test_permissions/test_get_at_different_privilege_levels) - Exclude exceptions from coverage that are impossible to reach without creating a broken API. - Test that IsSuperOrNetworkAdminMember returns 401 for unauthenticated users (test_networks/test_networks_get_401_unauthorized).
- Pragma out more unreachable code paths. - Some of these code paths should to be reworked to ensure that production doesn't rely on them. - Pragma out skipped tests. - Added tests for conflicting labels and IDNA errors. - Added tests for some internal and previous untested code.
|
The next steps is to test https://github.com/unioslo/mreg/blob/master/mreg/signals.py and https://github.com/unioslo/mreg/blob/master/mreg/mqsender.py. There is no need to take that work into this PR. Opening for review. |
oyvindkolbu
suggested changes
Mar 22, 2023
- Test add_user_to_groups (limited scope) - Remove some overzealous pragmas. - Add comments for skipped tests.
oyvindkolbu
reviewed
Mar 23, 2023
- Code paths we should never reach aren't reached during tests...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually fixes #483
First pass: