-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template group creation #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pederhan
force-pushed
the
template-groups
branch
from
November 15, 2023 09:01
5600f52
to
10af10c
Compare
This reverts commit 5f26e19.
pederhan
force-pushed
the
template-groups
branch
from
March 19, 2024 09:12
0d91379
to
87d6f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to automatically create template groups for all managed host groups. Two new configuration options have been introduced to facilitate this:
On Zabbix <6.2, this feature will create the template groups as host groups instead.
The feature is disabled by default.
Version Checks
The
BaseProcess
class now fetches the Zabbix API version (always matches the Zabbix Server version) on instantiation and stores it in the attributeself.zabbix_version
, which allows each process to perform version checks without having to add boilerplate code for fetching and parsing version numbers first. The version is stored as apackaging.version.Version
object.Comparing version numbers should be done on the release portion of the version name against a tuple of major, minor, micro (patch) versions, i.e.:
And not
Version
objects against each other:The main difference is that comparing releases allows for using alpha, beta and rc versions of Zabbix with ZAC. If we compared two
Version
objects against each other, the application would assume certain features are not available when running these pre-release versions:Individual version number components can be accessed via attributes: