Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI on Windows fix #3410

Merged
merged 2 commits into from
Sep 14, 2022
Merged

ANSI on Windows fix #3410

merged 2 commits into from
Sep 14, 2022

Conversation

ChrisPenner
Copy link
Contributor

@ChrisPenner ChrisPenner commented Sep 13, 2022

Overview

M4 unfortunately resulted in strange console rendering on Windows:

image

I've reverted this change and instead tried altering the Haskeline dep to commit d6c2643b0d5c19be7e440615c6f84d603d4bc648 which is mentioned in this pr. It seems to resolve this issue;

Tested in both Powershell and CMD prompt on my Windows 11 VM:

image


This change is Reviewable

@ChrisPenner ChrisPenner changed the title Cp/windows ansi ANSI on Windows fix Sep 13, 2022
@ChrisPenner ChrisPenner self-assigned this Sep 13, 2022
@ChrisPenner ChrisPenner marked this pull request as ready for review September 13, 2022 15:30
Copy link
Contributor

@aryairani aryairani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super

Copy link
Member

@mitchellwrosen mitchellwrosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supper

@aryairani aryairani merged commit d859b5e into trunk Sep 14, 2022
@aryairani aryairani deleted the cp/windows-ansi branch September 14, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants