GHC 964 Fixes #5106
Merged
GHC 964 Fixes #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* trivial additions of functor * limit imports to just used functions * remove unnecesary imports
neduard
force-pushed
the
ghc-964-updates-part-1
branch
2 times, most recently
from
a97106f to
4338758
Compare
-Wforall-identifier
this caused a weird type error
neduard
force-pushed
the
ghc-964-updates-part-1
branch
from
4338758 to
4453fda
Compare
ChrisPenner
reviewed
Jun 25, 2024
| @@ -22,6 +22,12 @@ type Referent' t h = Referent.Referent' (Reference' t h) (Reference' t h) | |||
| data TermEdit' t h = Replace (Referent' t h) Typing | Deprecate | |||
| deriving (Eq, Ord, Show) | |||
|
|
|||
| instance Functor (TermEdit' t) where | |||
There was a problem hiding this comment.
Can this instance not be derived? If not I'm curious why :)
Nevermind, saw the discussion in the prior PR, I'd guess it's due to the use of a type alias rather than a concrete type in the data definition.
ChrisPenner
approved these changes
Jun 25, 2024
aryairani
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up from #5096 . This PR should contain only non-breaking and hence compile with the current supported GHC version 9.2.8.
No functional changes.
Tests
NOTE: I haven't tested it yet with stack - will add comment later
For testing with GHC 964, I applied the additional changes in the above PR as this PR alone won't compile due to package updates introducing non-backward-compatible changes. I then ran
cabal v2-test allandcabal run transcripts:✅ 276 tests passed, no failures! 👍 🎉Loose ends
For testing, I've had also had to pin
lsp == 2.2.0.0,servant <= 0.20.1(currently it is<= 0.19.1).