-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to LTS 22.26 GHC 9.6.5 #5142
Changes from 20 commits
2d1bf19
61b2666
4a9b358
61e0522
745660d
a7f234a
f3d4455
7538111
b85bea8
87e15d7
06e730d
c97d93e
a35d706
95a0eb9
c3fe983
5dcc096
e94f870
563e148
8f694f1
15f236a
121d51c
d0f4c70
01e0351
a5b9864
ba13de4
86819b8
110b5ca
f25af69
dad9d6d
7b373d7
f2c8020
5ae7963
c47bdcf
ecf5fe1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Contributed by neduard for keeping the cabal build up to date. I haven't tested this myself. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,10 +27,10 @@ | |
] | ||
(system: let | ||
versions = { | ||
ghc = "928"; | ||
ghc = "965"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change doesn't actually work. |
||
ormolu = "0.5.2.0"; | ||
hls = "2.4.0.0"; | ||
stack = "2.13.1"; | ||
hls = "2.9.0.0"; | ||
stack = "2.15.5"; | ||
hpack = "0.35.2"; | ||
}; | ||
overlays = [ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,7 +172,7 @@ execute conn@(Connection _ _ conn0) sql@(Sql s params) = do | |
-- | ||
-- This function does not support parameters, and is mostly useful for executing DDL and migrations. | ||
executeStatements :: Connection -> Text -> IO () | ||
executeStatements conn@(Connection _ _ (Sqlite.Connection database)) sql = do | ||
executeStatements conn@(Connection _ _ (Sqlite.Connection database _tempNameCounter)) sql = do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This type just changed. |
||
logQuery (Sql sql []) Nothing | ||
Direct.Sqlite.exec database sql `catch` \(exception :: Sqlite.SQLError) -> | ||
throwSqliteQueryException | ||
|
@@ -184,7 +184,7 @@ executeStatements conn@(Connection _ _ (Sqlite.Connection database)) sql = do | |
|
||
-- With results, without checks | ||
|
||
queryStreamRow :: Sqlite.FromRow a => Connection -> Sql -> (IO (Maybe a) -> IO r) -> IO r | ||
queryStreamRow :: (Sqlite.FromRow a) => Connection -> Sql -> (IO (Maybe a) -> IO r) -> IO r | ||
queryStreamRow conn@(Connection _ _ conn0) sql@(Sql s params) callback = | ||
run `catch` \(exception :: Sqlite.SQLError) -> | ||
throwSqliteQueryException | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also change the default on
unisonweb/actions/stack/install
if we like that better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I figured it was a bit of a chicken-and-egg thing. TBH I kind of like specifying here because it's easy to see what it's using and easy to bump again in the future 😄
I'm glad you added it as an arg for that step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I like specifying it in this project too; I just wish we didn't have to specify it 4 times in this project, but maybe that's fine. Replace All.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can read JSON in GH workflows, and also in Nix (I don’t know if there are other places we need versions).
So, we could write a
dependency-versions.json
file or something that the flake can read into itsversions
attrSet, and that workflows can read as well. I’ve been wanting to extract it from the flake anyway.