Support native compilation on non-GNU Unix systems #5237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required if compiling on systems that use eg libressl
this is more portable and ensures we can compile on systems without bash (eg *BSD)
|
I haven’t tried this out, but the changes look good to me in principle, and I agree with the motivations. |
dolio
approved these changes
Jul 18, 2024
dolio
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently only tested on OpenBSD, but the hope is to more easily support non-GNU systems. Two main changes:
libb2for all blake2 related functions. This is because blake2 is not supported at the moment by LibreSSLshinjit-tests.sh. This ensures it can run on systems where bash isn't installed by default.(cc @dolio as I think you've been quite involved in the native compilation? Curious to hear your thoughts on this!)
Interesting/controversial decisions
One could argue that the vast majority of users will be on Windows/Linux/Mac. However, I think it's important in general to strive for portable software. The more systems software can run on, the less chances of system/implementation-specific issues cropping up.
Test coverage
Relying mostly on CI . Manually ran
jit-tests.shlocally on Mac.Loose ends
I've also updated the README for the scheme-libs here #5238
Tests are currently failing because of outdated scripts. That is fixed in #5236