bugfix: call lspCheckForChanges in more places, such as after a failed merge #5545
+30
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes LSP for in-progress merges. I couldn't find a ticket for this issue, but basically, LSP wouldn't properly refresh on merge failure.
Now, it does. I've tested this change manually by setting up the following merge:
LCA
Alice
Bob
When merging bob into alice, we end up with a file that looks like
where
baz
is in the underlying namespace, because it was an unconflicted add.Prior to this PR, LSP would complain that
baz
is out of scope.