Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing #1

Closed
wants to merge 24 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4262d86
Upgrade to angular 17
tmrdlt Jan 11, 2024
840b3a1
Add /.angular/cache to .gitignore
tmrdlt Jan 11, 2024
29720bf
Update peerDependencies, author and repository in package.json, updat…
tmrdlt Jan 15, 2024
3981541
Update Angular Version Compatibility section in README.md
tmrdlt Jan 15, 2024
7b67eba
Add unit tests for TagCommanderService
tmrdlt Jan 16, 2024
fab0a32
Fix sample app tests
tmrdlt Jan 16, 2024
b494a54
Migrate from tslint to eslint
tmrdlt Jan 16, 2024
0648804
Remove deprecated protractor
tmrdlt Jan 16, 2024
e45e6be
Fix sample app linting errors
tmrdlt Jan 16, 2024
2565f7c
Add github action for linting and testing
tmrdlt Jan 16, 2024
99cb8d9
Delete tslint.json files
tmrdlt Jan 17, 2024
db45b89
Add tests for TcEventDirective and TcSetVarsDirective
tmrdlt Jan 17, 2024
6084df5
Test reloadContainer on route change in TagCommanderService spec
tmrdlt Jan 17, 2024
ac1885e
Re-add cycle.ong, ddd font
tmrdlt Jan 17, 2024
7ede096
Render readme in sample app, add postbuild and postinstall hooks to c…
tmrdlt Jan 17, 2024
018bef3
Fix tests
tmrdlt Jan 17, 2024
a8d2727
Change name of shop items
tmrdlt Jan 18, 2024
056fb73
Update documentation
tmrdlt Jan 18, 2024
2a1db36
Add section about SSR to README.md
tmrdlt Jan 23, 2024
b5a1dca
Adds CONTRIBUTE.md
kenodressel Jan 23, 2024
fc48478
Move log in reloadContainer to the actual moment of reloading
tmrdlt Jan 23, 2024
14e25bc
Adjust wrapper functions parameter namings for consistency
tmrdlt Jan 25, 2024
d60bdd5
Update documentation link
tmrdlt Jan 25, 2024
2782139
Update link in section about Exclusions
tmrdlt Jan 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update link in section about Exclusions
  • Loading branch information
tmrdlt committed Jan 29, 2024
commit 27821391f3f5817ee661b8bed0b65e8ad2fac607
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -179,13 +179,13 @@ tcService.captureEvent(eventLabel, htmlElement, data);

### Reloading Containers <a name="reloading-containers"></a>

#### 1 Manual Reload
#### Manual Reload
Update your container after any variable change.
```typescript
tcService.reloadContainer(sideId, containerId, options);
```

#### 2. On Route Change
#### On Route Change
Automatic reload can be performed on route change.
1. Enable the service's route tracking in the app configuration:
```typescript
@@ -237,7 +237,7 @@ tcInclude: [{
}
}];
```
Please see the [container's documentation](https://doc.commandersact.com/features/sources/sources-catalog/web/containers) for other options.
Please see the [container's documentation](https://doc.commandersact.com/features/sources/sources-catalog/web/containers/setup-guides-for-developers/spa-implementation-guide#id-2.how-to-implement-tagcommander-in-an-spa-environment) for other options.

## Server-side Rendering (SSR) <a name="server-side-rendering"></a>
`ngx-tag-commander` fully supports Server-side rendering (SSR), as it comes with an internal check to run the code only on the client-side.
Loading