Test: TasksService, ImporterService, ValidatorService #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmrdlt
force-pushed
the
test/history-tasks
branch
from
16ec380 to
45341c2
Compare
kenodressel
reviewed
Mar 20, 2024
Comment on lines
-46
to
-48
| - name: npm lint | ||
| run: npm run lint | ||
|
|
There was a problem hiding this comment.
would be nice to keep this somewhere
There was a problem hiding this comment.
As mentioned above, I removed it because linting now also happens in the Code Check CI (At least npm run lint:check. npm run lint also fixes potential errors, but I don't see why this is needed in the tests).
kenodressel
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TasksServiceTasksService,ImporterServiceandValidatorServiceworkflows/test.yml:lint.yml)AppModule(which includes theTasksModule) was imported in the e2e tests leading to the execution of the CronJobs and the failure of the tests. We now import only the necessary modules.