Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: import paths #22

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Refactor: import paths #22

merged 2 commits into from
Apr 17, 2024

Conversation

tmrdlt
Copy link
Member

@tmrdlt tmrdlt commented Apr 16, 2024

  • Use absolute import paths using path aliases
  • Sort imports using eslint plugin

@tmrdlt tmrdlt self-assigned this Apr 16, 2024
@tmrdlt tmrdlt changed the title refactor: use absolute import paths and sort imports with eslint Refactor: import paths Apr 16, 2024
@tmrdlt tmrdlt requested a review from kenodressel April 16, 2024 13:36
@tmrdlt tmrdlt marked this pull request as ready for review April 16, 2024 13:52
kenodressel
kenodressel reviewed Apr 17, 2024
View reviewed changes
src/main.ts Outdated
import { DocumentBuilder, SwaggerModule } from '@nestjs/swagger';

import { AppModule } from './app.module';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tmrdlt tmrdlt force-pushed the refactor/import-paths branch from 830f94c to 5bc2a51 Compare April 17, 2024 09:40
Base automatically changed from feat/parse-events to feat/grant-2 April 17, 2024 09:43
@tmrdlt tmrdlt force-pushed the refactor/import-paths branch from 02b861b to 48347e7 Compare April 17, 2024 09:43
@tmrdlt tmrdlt merged commit 0b68c0d into feat/grant-2 Apr 17, 2024
2 checks passed
@tmrdlt tmrdlt deleted the refactor/import-paths branch April 17, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenodressel kenodressel kenodressel approved these changes

Assignees

@tmrdlt tmrdlt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmrdlt @kenodressel