Feat: Fetch fiat price #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmrdlt
force-pushed
the
feat/fetch-fiat-price
branch
3 times, most recently
from
5016c87 to
cae619e
Compare
tmrdlt
force-pushed
the
feat/fetch-fiat-price
branch
from
cae619e to
72605bb
Compare
kenodressel
approved these changes
Apr 25, 2024
Comment on lines
+95
to
+97
| const result = await this.get<MdwPaginatedResponse<T>>( | ||
| next + `&int-as-string=${this.INT_AS_STRING}`, | ||
| ); |
There was a problem hiding this comment.
minor notes: should have been its own PR
| expect.anything(), | ||
| ); | ||
| }); | ||
|
|
There was a problem hiding this comment.
should we test what happens if we run in the rate limit error?
There was a problem hiding this comment.
Sounds good, I'd add it to the importer spec however, as in the CoinmarketcapClieht nothing much happens besides returning the error (we are using a mocked version of the API).
| service.getHistoricalPriceDataThrottled(1704203935123); | ||
| service.getHistoricalPriceDataThrottled(1704203935123); | ||
|
|
||
| await new Promise((res) => setTimeout(res, 200)); |
There was a problem hiding this comment.
seems a bit flaky, could we await the first two calls and then for the third call use the timeout?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoinmarketcapClientfor fetching fiat price on log basis including throttelingHttpServiceint-as-stringparam not being present in paginated calls