Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Remove history v1 #29

Merged
merged 3 commits into from
May 29, 2024
Merged

Refactor: Remove history v1 #29

merged 3 commits into from
May 29, 2024

Conversation

tmrdlt
Copy link
Member

@tmrdlt tmrdlt commented Apr 25, 2024 •
edited
Loading

  • Deleted ImporterV1, ValidatorV1, HistoryV1Db, HistoryV1ErrorDb
  • Renamed ImporterV2, ValidatorV2, HistoryV2Db, HistoryV2ErrorDb to Importer, Validator, HistoryDb, HistoryErrorDb
  • Kept history API but added TODOs to adjust later

@tmrdlt tmrdlt self-assigned this Apr 25, 2024
@tmrdlt tmrdlt force-pushed the refactor/remove-history-v1 branch from 9ec0a79 to 4a92616 Compare April 25, 2024 12:15
@tmrdlt tmrdlt requested a review from kenodressel April 25, 2024 14:06
@tmrdlt tmrdlt marked this pull request as ready for review April 25, 2024 14:06
kenodressel
kenodressel reviewed Apr 26, 2024
View reviewed changes
Copy link

@kenodressel kenodressel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Can we take note of the things that we are skipping in this PR so we at least have some record of tech debt that we need to clean later?

src/api/pair-liquidity-info-history/pair-liquidity-info-history.controller.spec.ts Show resolved Hide resolved
@tmrdlt tmrdlt force-pushed the refactor/remove-history-v1 branch from 4a92616 to 3db9f6b Compare May 6, 2024 12:41
@tmrdlt
Copy link
Member Author

tmrdlt commented May 6, 2024

I created a task for the tech debt which consists of the API migration.

@tmrdlt tmrdlt force-pushed the refactor/remove-history-v1 branch from af8b5f1 to bf89e14 Compare May 6, 2024 13:13
@tmrdlt tmrdlt requested a review from kenodressel May 6, 2024 14:16
@kenodressel kenodressel merged commit fe8331b into feat/fetch-fiat-price May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenodressel kenodressel kenodressel approved these changes

Assignees

@tmrdlt tmrdlt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmrdlt @kenodressel