Fix(history-importer): Move check for recent log error to correct place #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tmrdlt
commented
Oct 16, 2024
tmrdlt
commented
- ATM the check is only made after every logic for a log is already executed, which doesn't make much sense
- Moved the check at the start of the logic executed for every log, so it really skips the execution if a recent error occured
kenodressel
approved these changes
Oct 16, 2024
tmrdlt
force-pushed
the
fix/recent-log-error-check
branch
from
c1deed7 to
aaba985
Compare
tmrdlt
changed the title
tmrdlt
force-pushed
the
fix/recent-log-error-check
branch
from
3078c73 to
d0310b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.