Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added namespace #85

Merged
merged 25 commits into from
May 5, 2023
Merged

added namespace #85

merged 25 commits into from
May 5, 2023

Conversation

krgrsebastian
Copy link
Contributor

Description

added description to change namespace in lens

Related issues

#76

Type of change

What types of changes does your code introduce to this project?

  • [ x] Bug fix (non-breaking change which fixes an issue)

@krgrsebastian krgrsebastian requested a review from a team March 14, 2023 14:51
@krgrsebastian krgrsebastian self-assigned this Mar 14, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 14, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5681812
Status: ✅  Deploy successful!
Preview URL: https://f9f15569.umh-docs-umh-app.pages.dev
Branch Preview URL: https://fix-76-specify-namespace.umh-docs-umh-app.pages.dev

View logs

DaruZero
DaruZero suggested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@DaruZero DaruZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button names should be capitalized. e.g. Workloads -> Pods

umh.docs.umh.app/content/en/docs/getstarted/managingthesystem.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Mar 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Scarjit
Copy link
Member

Scarjit commented Apr 6, 2023

@JeremyTheocharis Can you check the CLA error here ?

@krgrsebastian krgrsebastian requested a review from DaruZero April 28, 2023 08:55
DaruZero
DaruZero suggested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@DaruZero DaruZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you consider opening a new issue regarding the styling of the whole getstarted section?

umh.docs.umh.app/content/en/docs/getstarted/managingthesystem.md Outdated Show resolved Hide resolved
umh.docs.umh.app/content/en/docs/getstarted/managingthesystem.md Outdated Show resolved Hide resolved
@krgrsebastian krgrsebastian requested a review from DaruZero April 28, 2023 09:14
DaruZero
DaruZero approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@DaruZero DaruZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Remember to squash

@JeremyTheocharis JeremyTheocharis merged commit 0c97931 into main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaruZero DaruZero DaruZero approved these changes

@JeremyTheocharis JeremyTheocharis JeremyTheocharis approved these changes

Assignees

@krgrsebastian krgrsebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krgrsebastian @CLAassistant @Scarjit @JeremyTheocharis @DaruZero