feat: mqtt, kafka, console use loadbalancer #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-js-for-copy-function-in-codenew-shortcode feat: implement copy button
* feat: first draft of Unified Namespace * feat: added historian * added links to features * added documentation for datasource v1 and v2 * added matteos and jeremys feedback * shortcodes * added analytics section * finished --------- Co-authored-by: krgrsebastian <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Update |
JeremyTheocharis
requested changes
Mar 17, 2023
Merged
6 tasks
I think it's fine if latest changes of main get merged into dev branch, since they will be added regardless sooner or later |
Scarjit
approved these changes
Mar 21, 2023
|
The problem is with this that I would still need to review the content of all the 36 files, which is kind of unnecessary. Better would be to only merge the changes, and then do a PR to bring dev to the latest release of main (so two PRs). |
|
Let's wait on #58 to be merged, then I'll fix this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the pages for MQTT Broker and Kafka Console, as well as the Helm chart parameters with the new LoadBalancer services used by MQTT Broker, Kafka Broker and Kafka Console.
Related issues
united-manufacturing-hub/united-manufacturing-hub#1482
Type of change
What types of changes does your code introduce to this project?
Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Additional information
Wait for united-manufacturing-hub/united-manufacturing-hub#1487 before merging