chore: add "why rust?" section #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Danny Lee <[email protected]>
|
Looks pretty good! Thanks for catching a few bugs. A few requests:
|
|
@abrassel got you! I could only think of tiktoken/tokenizers/pydantic off the top of my head, feel free to edit the branch if you have any others |
|
I don't have any off the top of my head! This looks great. |
abrassel
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "why rust?" section based on thoughts in the slack. Closes #4.
Also updates the Code of Conduct from the main Java repo (thank you @dennyglee!)