Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

remove all onSuccessCallback params #62

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

jamieknight-db
Copy link
Collaborator

@jamieknight-db jamieknight-db commented Aug 8, 2024

Removing all onSuccessCallback parameters in hooks, they are not needed and can be handled in mutation onSuccess instead.

@jamieknight-db
Copy link
Collaborator Author

@xx-db please review when you have a moment

Copy link
Collaborator

@yc-shawn yc-shawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Assuming you already manually tested those

Copy link
Collaborator

@Romanize Romanize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, can you double check the invalidations are working properly?

@jamieknight-db
Copy link
Collaborator Author

Thanks!

Assuming you already manually tested those

@yc-shawn yes they have been tested and working as expected

@jamieknight-db
Copy link
Collaborator Author

Looks nice, can you double check the invalidations are working properly?

@Romanize everything is working as it was before, but I noticed the tree view browser is not updating after any of the invalidateQueries (which was an existing issue). It's bothering me so I am looking into a fix.

@jamieknight-db
Copy link
Collaborator Author

Going to merge this and circle back to the issue of refreshing the tree view. I haven't been able to find a solution.

@jamieknight-db jamieknight-db merged commit dd4f528 into main Aug 8, 2024
1 check passed
@jamieknight-db jamieknight-db deleted the fix-delete-onSuccess branch August 8, 2024 19:44
rtyler pushed a commit to rtyler/unitycatalog that referenced this pull request Sep 6, 2024
rtyler pushed a commit to rtyler/unitycatalog that referenced this pull request Sep 6, 2024
dennyglee pushed a commit to unitycatalog/unitycatalog that referenced this pull request Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants