Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

fix schema browser not subscribing to query client #64

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

xx-db
Copy link
Contributor

@xx-db xx-db commented Aug 8, 2024

No description provided.

Copy link
Collaborator

@jamieknight-db jamieknight-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU @xx-db this was driving me nuts yesterday, I had to step away 😵‍💫 was the main fix to move the queryClient out of the AppProvider?

@xx-db
Copy link
Contributor Author

xx-db commented Aug 9, 2024

THANK YOU @xx-db this was driving me nuts yesterday, I had to step away 😵‍💫 was the main fix to move the queryClient out of the AppProvider?

haha it was bugging me too. Yes the main fix is to move the queryClient out, this one is just hard to debug but the fix is pretty straightforward. The other changes just made it cleaner. We don't have to include those if there are strong opinions.

@jamieknight-db
Copy link
Collaborator

THANK YOU @xx-db this was driving me nuts yesterday, I had to step away 😵‍💫 was the main fix to move the queryClient out of the AppProvider?

haha it was bugging me too. Yes the main fix is to move the queryClient out, this one is just hard to debug but the fix is pretty straightforward. The other changes just made it cleaner. We don't have to include those if there are strong opinions.

The inconsistency was my hurdle, the tree view would update sometimes but mostly not. All the changes look good to me - thanks again!

Copy link
Collaborator

@yc-shawn yc-shawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for capture and fix this!

@jamieknight-db jamieknight-db merged commit 109604b into unitycatalog:main Aug 12, 2024
1 check passed
dennyglee pushed a commit to unitycatalog/unitycatalog that referenced this pull request Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants