This repository has been archived by the owner on Sep 6, 2024. It is now read-only.
Feat/login UI #73
Merged
Feat/login UI #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/App.tsx
# Conflicts: # src/hooks/catalog.tsx
clean up some other endpoints
|
@xx-db looks like we are getting a failure with the node version in the |
yc-shawn
reviewed
Aug 28, 2024
yc-shawn
approved these changes
Aug 29, 2024
creechy
reviewed
Aug 29, 2024
| @@ -0,0 +1,11 @@ | |||
| import axios from 'axios'; | |||
There was a problem hiding this comment.
no biggie but just to check, could refactoring to use the axios client have happened independently of the "login ui" or are they intertwined?
There was a problem hiding this comment.
Refactoring to use axios can happen independently. It's more of a dependency for the UI work.
xx-db
approved these changes
Aug 29, 2024
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
* start of login page * env and google auth button * merge with main, remove params reference * start of okta auth * initial commit for handling auth token (unitycatalog#67) * start of login with keycloak * handle google sign in with token * more google auth * profile dropdown * merge with main * merge with main * convert to axios * start of readme instructions * get current user endpoint (unitycatalog/unitycatalog-ui#70) clean up some other endpoints * commenting out UI until repositories are merged * clean up current user (unitycatalog/unitycatalog-ui#74) * yarn lock file * remove keycloak for now, node version error in jwt-decode dependency * commit yarn lock * remove state as useEffect dependency, comment out currentUser call for now --------- Co-authored-by: Xiang Xu <[email protected]>
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
* start of login page * env and google auth button * merge with main, remove params reference * start of okta auth * initial commit for handling auth token (unitycatalog#67) * start of login with keycloak * handle google sign in with token * more google auth * profile dropdown * merge with main * merge with main * convert to axios * start of readme instructions * get current user endpoint (unitycatalog/unitycatalog-ui#70) clean up some other endpoints * commenting out UI until repositories are merged * clean up current user (unitycatalog/unitycatalog-ui#74) * yarn lock file * remove keycloak for now, node version error in jwt-decode dependency * commit yarn lock * remove state as useEffect dependency, comment out currentUser call for now --------- Co-authored-by: Xiang Xu <[email protected]>
dennyglee
pushed a commit
to unitycatalog/unitycatalog
that referenced
this pull request
Sep 6, 2024
* start of login page * env and google auth button * merge with main, remove params reference * start of okta auth * initial commit for handling auth token (#67) * start of login with keycloak * handle google sign in with token * more google auth * profile dropdown * merge with main * merge with main * convert to axios * start of readme instructions * get current user endpoint (unitycatalog/unitycatalog-ui#70) clean up some other endpoints * commenting out UI until repositories are merged * clean up current user (unitycatalog/unitycatalog-ui#74) * yarn lock file * remove keycloak for now, node version error in jwt-decode dependency * commit yarn lock * remove state as useEffect dependency, comment out currentUser call for now --------- Co-authored-by: Xiang Xu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only supporting google auth for v1, okta and keycloak will be follow on PR's. Commenting out the UI until repositories are merged. But here are screenshots so far. The current user endpoint is not ready yet.