Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS Crash ffix 938 #236

Merged
merged 2 commits into from
Jan 10, 2025
Merged

TTS Crash ffix 938 #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b1b3a1
TTS Crash ffix
Bod9001 Dec 21, 2024
fb3e552
Update UnitystationLauncher/Assets/org.unitystation.StationHub.metain…
corp-0 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions UnitystationLauncher/Assets/org.unitystation.StationHub.metainfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@
</screenshots>

<releases>
<release version="938" date="2024-12-13">
<description>
<p>Fix:</p>
<ul>
<li>Fixed an issue where TTS errors would crash the entire TTS system</li>
</ul>
</description>
</release>
<release version="937" date="2024-12-13">
<description>
<p>Fix:</p>
Expand Down
2 changes: 1 addition & 1 deletion UnitystationLauncher/Constants/AppInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ public static class AppInfo
{
// Whenever you change the currentBuild here, please also update the one in
// UnitystationLauncher/Assets/org.unitystation.StationHub.metainfo.xml
public const int CurrentBuild = 937;
public const int CurrentBuild = 938;
}
2 changes: 0 additions & 2 deletions UnitystationLauncher/Services/TTSService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

public class TTSService : ITTSService
{
private static string _nameConfig = @"CodeScanList.json";

Check warning on line 31 in UnitystationLauncher/Services/TTSService.cs

View workflow job for this annotation

GitHub Actions / Build MacOS 

The field 'TTSService._nameConfig' is assigned but its value is never used

Check warning on line 31 in UnitystationLauncher/Services/TTSService.cs

View workflow job for this annotation

GitHub Actions / Build Linux 

The field 'TTSService._nameConfig' is assigned but its value is never used

Check warning on line 31 in UnitystationLauncher/Services/TTSService.cs

View workflow job for this annotation

GitHub Actions / Build Windows 

The field 'TTSService._nameConfig' is assigned but its value is never used

Check warning on line 31 in UnitystationLauncher/Services/TTSService.cs

View workflow job for this annotation

GitHub Actions / Build Linux Flatpak 

The field 'TTSService._nameConfig' is assigned but its value is never used

Check warning on line 31 in UnitystationLauncher/Services/TTSService.cs

View workflow job for this annotation

GitHub Actions / test 

The field 'TTSService._nameConfig' is assigned but its value is never used

private readonly HttpClient _httpClient;

Expand Down Expand Up @@ -298,8 +298,6 @@
ArgumentList = { arguments },
UseShellExecute = false, // Don't use the shell
CreateNoWindow = true, // Run without creating a window
RedirectStandardOutput = true, // Optional: Redirect output for logging
RedirectStandardError = true, // Optional: Redirect error output
};

if (startInfo == null)
Expand Down
Loading