Add automated docker server builds. #2947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedlineTriad
added
Type: Feature
RedlineTriad
added
the
Status: DNM
Jibbajabbafic
added
the
Status: In Progress
Contributor
|
Got pushing to docker working, but haven't tested the image itself. Will merge for now since I trust you tried it out already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds: #2520
This automates building docker server image and pushing it to dockerhub.
Notes:
@DooblyNoobly already set up creds for upload in main repository.
Buildnumber isn't currently set automatically.
Rcon doesn't work because of #2884 unless hub creds are set (only @DooblyNoobly has valid ones)