feat: increase target of tsc to es2022 #985
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So @gdp88 was trying to use
sinonto mock the sdk, but was encountering issues. The root cause is that the SDK was still compiling down to an old version ofesand was producing:instead of
Setting the properties inside the contructor makes them invisible because they are not part of the prototype until the contructor is actually run. You can see here in this experiment I ran inside the repl:
This shouldn't really be a breaking change though, I kept the cjs version as before, any any system that's actually supported and running the
esmversion under node should also support the es2022 syntax, and allow us to test using sinon in the services repo