-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asciidoc: new parser #1838
Asciidoc: new parser #1838
Conversation
I didn't do this because the version of GPL of the orignal code is not written explictly. |
@masatake However, as the PR doesn't change the licensing header, I'd think it just makes this file whichever version, doesn't it? Or is it a problem because v3 is incompatible with v1 in a way that cannot be mixed in an executable? |
Well, as the comment at the top says, I copied most of it from the rest parser, including the license section. As that was explicitly included in Geany by the original copyright holder that would make it GPL v2+ in the absence of any other version info. [Edited, oops accidentally commented too early] |
@elextr, thank you.
It seems that the siltation is similar to old Universal-ctags. However, the asciidoc parser submitted here leaves the original Geany source tree when this |
Actually Geany itself is licensed GPL V2 but most of the source has the usual "V2 or later" text.
Given that Nick (the copyright holder of the rest parser I copied and modified) committed the rest parser to Geany himself back in 2007, he was just copying the then standard Exuberant-ctags approach and clearly intended the Geany license (GPL v2) to cover it. And GPL V2 states "...If the Program does not specify a version number of this License, you may choose any version...". As the file is being removed from Geany @masatake is right this PR just needs to make the version explicit as above, and also add
to cover the material originally copied from the rest parser. I note that ctags rest parser is still copyright Nick and has the V2 or later added. |
done. |
@hadrielk, thank you. I will update rst.c side. |
Could you add this sentence to the commit log for 1eb07f9. |
@@ -38,6 +38,7 @@ The following parsers have been added: | |||
|
|||
* Ada | |||
* AnsiblePlaybook *libyaml* | |||
* Asciidoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine!
LGTM. |
This ports the Asciidoc parser from geany, fixes a bug in it, and adds tagging of anchors. (other than anchors inline in one-line titles)