Units: Add unit tests for null tags #4157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests in various languages (JSON, Tcl, Verilog/SystemVerilog)
to test if null tags are properly implemented.
Note that Tcl doesn't support empty namespace names using `::` syntax
since `foo::::bar` is synonymous of `foo::bar`, so we're not testing
empty namespace names there, only empty proc names.
Note that the current Tcl parser doesn't seem to support
{braced} identifiers at all (including the empty identifier),
so perhaps adding support for null tags in Tcl is trickier.
Closed
|
As discussed in #4151, this PR would fail the CI tests (and it indeed did). This is expected. (On a side note, I need to configure these CI tests so that I don't receive a dozen email notifications every time I push a PR that doesn't pass the tests.) |
|
Thank you. I will merge/cherry-pick incrementally. |
masatake
added a commit
to masatake/ctags
that referenced
this pull request
Jan 1, 2025
The test case is taken from universal-ctags#4157 submitted by Javier Mora. Co-authored-by: Javier Mora <[email protected]> Signed-off-by: Masatake YAMATO <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is related to #4151.)
Add unit tests in various languages (JSON, Tcl, Verilog/SystemVerilog) to test if null tags are properly implemented.
Note that Tcl doesn't support empty namespace names using
::syntax sincefoo::::baris synonymous offoo::bar, so we're not testing empty namespace names there, only empty proc names.Note that the current Tcl parser doesn't seem to support {braced} identifiers at all (including the empty identifier), so perhaps adding support for null tags in Tcl is trickier.
(Maybe I should remove Tcl entirely from the test since it currently doesn't seem to support empty identifiers due to this, and these tests are for testing empty identifiers in general and not a language in particular.)