Use "unsigned char" instead of "char" when comparing byte sequences #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original bug was found when developing Juila parser in u-ctags
repo[1]. When searching a tag name "α", readtags reported nothing
though an entry for "α" was in the tags file used for testing
the Julia parser.
"α" is {206, 177} as a byte sequence.
However, when comparing bytes in strings, libreadtags used (singed)
char type. In the case "α" was {-50, -79}. Using {-50, -79} for
comparison, the binary search didn't work as we expected.
The test for this change will be done in u-ctag side.
[1] universal-ctags/ctags#2654
Signed-off-by: Masatake YAMATO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original bug was found when developing Juila parser in u-ctags
repo[1]. When searching a tag name "α", readtags reported nothing
though an entry for "α" was in the tags file used for testing
the Julia parser.
"α" is {206, 177} as a byte sequence.
However, when comparing bytes in strings, libreadtags used (singed)
char type. In the case "α" was {-50, -79}. Using {-50, -79} for
comparison, the binary search didn't work as we expected.
The test for this change will be done in u-ctag side.
[1] universal-ctags/ctags#2654
Signed-off-by: Masatake YAMATO [email protected]