Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): remove query params from image id #206

Closed
wants to merge 1 commit into from
Closed

Conversation

Ayax0
Copy link

@Ayax0 Ayax0 commented Jan 6, 2024

πŸ”— Linked issue

#205

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The query parameters are removed from the image url to allow further information relevant to the server to be provided via query parameters.
Resolves #205

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member

pi0 commented Jan 11, 2024

Thanks for spending time on this PR. I have explained little more in #205 (comment) I think it should be really common and also opt-in behavior to strip query params like this from source.

For now closing PR (mainly for triage) but would love to discuss and reconsider this change.

@pi0 pi0 closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query parameter falsifies the image id
2 participants