Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgradeDependency utility #82

Closed
wants to merge 7 commits into from

Conversation

rishi-raj-jain
Copy link

@rishi-raj-jain rishi-raj-jain commented Aug 14, 2023

fix #78

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #82 (3f7a75d) into main (c16de18) will decrease coverage by 14.70%.
Report is 2 commits behind head on main.
The diff coverage is 14.94%.

@@             Coverage Diff             @@
##             main      #82       +/-   ##
===========================================
- Coverage   98.02%   83.33%   -14.70%     
===========================================
  Files           5        5               
  Lines         405      492       +87     
  Branches       64       64               
===========================================
+ Hits          397      410       +13     
- Misses          8       82       +74     
Files Changed Coverage Δ
src/_utils.ts 71.27% <7.40%> (-27.16%) ⬇️
src/api.ts 83.42% <27.27%> (-12.53%) ⬇️

@pi0 pi0 changed the title feat: upgradeDependency utility feat: upgradeDependency utility Aug 16, 2023
@rishi-raj-jain
Copy link
Author

Not sure how I missed adding those deps 😅

Thanks for taking the time on fixing these...

@pi0 pi0 self-assigned this Aug 16, 2023
@pi0
Copy link
Member

pi0 commented Aug 16, 2023

Thanks for PR dear @rishi-raj-jain. I have made few more refactors (it is halfway done sorry in between projects). I think this is a really good start. Will followup later.

@rishi-raj-jain
Copy link
Author

Thanks for PR dear @rishi-raj-jain. I have made few more refactors (it is halfway done sorry in between projects). I think this is a really good start. Will followup later.

Awesome! Do let me know if I can contribute. I think nypm shall also have like each function to do things, addDep, checkDep, updateDep, etc. But yeah ik the time is limited

@pi0 pi0 marked this pull request as draft March 3, 2024 15:39
@pi0
Copy link
Member

pi0 commented Mar 5, 2024

Hi and thanks for this PR again. I think it might be better to rethink about this functionality after introducing getPackageInfo (#7) and working with other registries.

@pi0 pi0 closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgradeDependency utility
2 participants