Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add myjson.online driver #366

Closed
wants to merge 5 commits into from
Closed

feat: add myjson.online driver #366

wants to merge 5 commits into from

Conversation

justboe
Copy link

@justboe justboe commented Jan 5, 2024

πŸ”— Linked issue

#325

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

This PR adds the myJson driver requested by issue #325. Also added basic documentation.

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

nuxt-studio bot commented Jan 5, 2024

βœ… Live Preview ready!

Name Edit Preview Latest Commit
unstorage Edit on Studio β†—οΈŽ View Live Preview beab2d3

@itpropro
Copy link
Member

itpropro commented Jan 6, 2024

Thanks a lot for your driver!
I am not really sure if we need an additional driver for this service, as there already is the general http driver. Is there any limitation that prevented you from using the http driver with custom TransactionOptions for headers using the opts parameter?

@pi0 pi0 added the driver label May 1, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 6.18557% with 91 lines in your changes missing coverage. Please review.

Project coverage is 61.33%. Comparing base (4d61c78) to head (232db00).
Report is 122 commits behind head on main.

Files with missing lines Patch % Lines
src/drivers/myjson.ts 5.20% 91 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   65.05%   61.33%   -3.72%     
==========================================
  Files          39       40       +1     
  Lines        4055     3440     -615     
  Branches      487      579      +92     
==========================================
- Hits         2638     2110     -528     
+ Misses       1408     1327      -81     
+ Partials        9        3       -6     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0
Copy link
Member

pi0 commented Dec 16, 2024

Thanks for the work on PR. I have made some refactors but reading docs it seems we cannot support current API because unstorage needs creating records with custom id (user key) but API returns a generated UUID which is incompatible.

@pi0 pi0 closed this Dec 16, 2024
@pi0 pi0 mentioned this pull request Dec 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants