Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deno-kv-node driver #391

Closed
wants to merge 9 commits into from
Closed

feat: add deno-kv-node driver #391

wants to merge 9 commits into from

Conversation

mavdotjs
Copy link

πŸ”— Linked issue

#224
close #233

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds deno KV support into unstorage using the @deno/kv npm module, which is supported on deno, node, and bun. Currently watch() is not supported because the deno kv watch requires parameters (a list of at max 10 keys to watch), which unstorage does not have.
Rewrote #233

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

nuxt-studio bot commented Jan 28, 2024

βœ… Live Preview ready!

Name Edit Preview Latest Commit
unstorage Edit on Studio β†—οΈŽ View Live Preview fe7519f

@mavdotjs
Copy link
Author

image 😎

@pi0 pi0 changed the title feat(drivers): Implement Deno KV feat: add deno-kv driver May 1, 2024
@pi0 pi0 added the driver label May 1, 2024
@pi0 pi0 changed the title feat: add deno-kv driver feat: add deno-kv-node driver Dec 11, 2024
@pi0 pi0 mentioned this pull request Dec 12, 2024
@pi0
Copy link
Member

pi0 commented Dec 13, 2024

Thank you so much for working on it dear @mavdotjs and sorry it got delayed

I made on a rework of #233 => #521 that adds Node.js client wrapper on top of it.

Of course if you had any feedbacks to improve please do feel free to make a PR to improve it.

@pi0 pi0 closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants