fix: allow omitting transaction options #483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying unstorage with
|
| Latest commit: |
ddfc00e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e7c05287.unstorage.pages.dev |
| Branch Preview URL: | https://fix-optional-opts.unstorage.pages.dev |
pi0
reviewed
Sep 11, 2024
| getItemRaw?: (key: string, opts: TransactionOptions) => MaybePromise<unknown>; | ||
| getItemRaw?: ( | ||
| key: string, | ||
| opts?: TransactionOptions |
There was a problem hiding this comment.
core sets it when calling drivers.
If in Storage it is not optional i think that is the mistake
pi0
force-pushed
the
fix/optional-opts
branch
2 times, most recently
from
fd7577e to
ddfc00e
Compare
|
@danielroe Do you remember where occured with this issue? I just checked only types are marking it as "set" in Can we close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue introduced in #250 requires an
optsargument to be passed to all driversthis may be intentional so feel free to close if so!