Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fallback to StorageValue for un-typed stores #532

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

danielroe
Copy link
Member

resolves #531

we didn't catch the issue because toMatchTypeOf doesn't mean what it sounds like

@danielroe danielroe requested a review from pi0 December 19, 2024 09:46
@danielroe danielroe self-assigned this Dec 19, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 19, 2024

Deploying unstorage with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1fd2e72
Status: ✅  Deploy successful!
Preview URL: https://bc7066ec.unstorage.pages.dev
Branch Preview URL: https://fix-default-types.unstorage.pages.dev

View logs

@pi0
Copy link
Member

pi0 commented Dec 19, 2024

thnx. i think one type issue is in storage.ts getItems is only now broken.

@pi0 pi0 merged commit 98d433e into main Dec 19, 2024
3 checks passed
@pi0 pi0 deleted the fix/default-types branch December 19, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getItem now returns Promise<null>
2 participants