feat: add flags key to driver interface
#552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `flags` to the `Driver` type which can be used in future to determine if a driver supports a particular feature or requires some behaviour.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
==========================================
- Coverage 65.05% 58.91% -6.15%
==========================================
Files 39 43 +4
Lines 4055 3680 -375
Branches 487 588 +101
==========================================
- Hits 2638 2168 -470
- Misses 1408 1508 +100
+ Partials 9 4 -5 ☔ View full report in Codecov by Sentry. |
pi0
reviewed
Dec 30, 2024
Co-authored-by: Pooya Parsa <[email protected]>
pi0
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #549
Adds
flagsto theDrivertype which can be used in future to determine if a driver supports a particular feature or requires some behaviour.maybe something like this @pi0 ? and in a separate PR, add the flags to the fs drivers