Make the install script more better #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binary naming convention has been updated to include OS and architecture information. The archive name template has also been modified for better organization. Additionally, extra files have been added to the release section, including provisioner distributions, an install script, and a service file.
The workflow has been updated to include a step for generating release artifacts. This involves creating 'install.sh' and 'baremetal-provisioner.service'. The Makefile has also been modified to handle the creation of these new artifacts.
Significant changes include: - Added a new systemd service file for the Pulumi Bare Metal Provisioner. - Enhanced the installation script with additional checks, logging, and functionality. This includes fetching the systemd unit file if it doesn't exist locally, creating a configuration directory and vars file, and setting up environment variables. - Improved user feedback messages in the installation script to provide more clarity.
The install.sh script in the provisioner command has been refactored for better readability and maintainability. The changes include: - Extracted variable printing into a separate function, printVars. - Simplified directory creation logic by removing unnecessary checks. - Added handling for DEV_MODE in fetching systemd unit file. - Included steps to reload systemd and enable service after configuration updates.
And also some other stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.